lkml.org 
[lkml]   [2018]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/3] ARM: dts: tegra: Fix unit_address_vs_reg and avoid_unnecessary_addr_size DTC warnings
On 17.05.2018 09:45, Krzysztof Kozlowski wrote:
> Remove unneeded address/size cells properties and unit addresses to fix
> DTC warnings like:
>
> arch/arm/boot/dts/tegra30-apalis-eval.dtb: Warning (unit_address_vs_reg):
> /i2c@7000d000/stmpe811@41/stmpe_touchscreen@0: node has a unit
> name, but no reg property
> arch/arm/boot/dts/tegra30-apalis-eval.dtb: Warning
> (avoid_unnecessary_addr_size):
> /i2c@7000d000/stmpe811@41: unnecessary
> #address-cells/#size-cells without "ranges" or child "reg" property
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Looks good!

Reviewed-by: Stefan Agner <stefan@agner.ch>

>
> ---
>
> Changes since v4:
> 1. None
> ---
> arch/arm/boot/dts/tegra30-apalis.dtsi | 4 +---
> arch/arm/boot/dts/tegra30-beaver.dts | 3 ---
> arch/arm/boot/dts/tegra30-colibri.dtsi | 2 --
> 3 files changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi
> b/arch/arm/boot/dts/tegra30-apalis.dtsi
> index 184f60c720fa..5038ca7b68af 100644
> --- a/arch/arm/boot/dts/tegra30-apalis.dtsi
> +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
> @@ -590,8 +590,6 @@
> /* STMPE811 touch screen controller */
> stmpe811@41 {
> compatible = "st,stmpe811";
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <0x41>;
> interrupts = <TEGRA_GPIO(V, 0) IRQ_TYPE_LEVEL_LOW>;
> interrupt-parent = <&gpio>;
> @@ -600,7 +598,7 @@
> blocks = <0x5>;
> irq-trigger = <0x1>;
>
> - stmpe_touchscreen@0 {
> + stmpe_touchscreen {
> compatible = "st,stmpe-ts";
> /* 3.25 MHz ADC clock speed */
> st,adc-freq = <1>;
> diff --git a/arch/arm/boot/dts/tegra30-beaver.dts
> b/arch/arm/boot/dts/tegra30-beaver.dts
> index 72369877d284..961934f70639 100644
> --- a/arch/arm/boot/dts/tegra30-beaver.dts
> +++ b/arch/arm/boot/dts/tegra30-beaver.dts
> @@ -1791,9 +1791,6 @@
> vccio-supply = <&vdd_5v_in_reg>;
>
> regulators {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> vdd1_reg: vdd1 {
> regulator-name = "vddio_ddr_1v2";
> regulator-min-microvolt = <1200000>;
> diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi
> b/arch/arm/boot/dts/tegra30-colibri.dtsi
> index cc46cedf80b9..a593dc8be47f 100644
> --- a/arch/arm/boot/dts/tegra30-colibri.dtsi
> +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
> @@ -352,8 +352,6 @@
> /* STMPE811 touch screen controller */
> stmpe811@41 {
> compatible = "st,stmpe811";
> - #address-cells = <1>;
> - #size-cells = <0>;
> reg = <0x41>;
> interrupts = <TEGRA_GPIO(V, 0) IRQ_TYPE_LEVEL_LOW>;
> interrupt-parent = <&gpio>;

\
 
 \ /
  Last update: 2018-05-17 13:31    [W:0.510 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site