[lkml]   [2018]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 3/4] coresight: allow to build as modules
On Wed, May 16, 2018 at 02:33:22PM -0500, Kim Phillips wrote:
> Allow to build coresight as modules. This greatly enhances developer
> efficiency by allowing the development to take place exclusively on the
> target, and without needing to reboot in between changes.
> - Kconfig bools become tristates, to allow =m
> - MODULE_* macros added: Please correct me if I'm wrong:
> - assume LICENSE is "GPL v2"
> - tried to get as close to original authors for MODULE_AUTHOR
> - The 'select' Kconfig statements are replaced with 'depends on'
> clauses, to specify the dependencies between the modules including
> other fixes, e.g., coresight-stm unconditionally calls
> stm_register_device, it therefore depends on STM.
> - use -objs to denote merge object directives in Makefile, adds a
> coresight-core nomenclature for the base module.
> - add a coresight_exit() that unregisters the coresight bus, add remove
> fns for most others.
> - fix up modules with ID tables for autoloading on boot, add missing
> __exit attributes
> - move coresight_vpid_to_pid to an externed, single instance in
> coresight-core, to be used by all submodules.

That's a ton of different things to be doing all at once in this patch.
Please break it up into logical steps (like you describe here!) which
will make it much easier and trivial to review.

As it is, I'm not even going to look at the mess-of-a-diff that I
imagine the above results in :)


greg k-h

 \ /
  Last update: 2018-05-17 09:08    [W:0.150 / U:1.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site