lkml.org 
[lkml]   [2018]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge
From
Date
On 05/16/2018 01:23 PM, Sinan Kaya wrote:
> + win_start = window->res->start - window->offset;

Can you guarantee that window->res->start is always >= window->offset?

> + win_size = window->res->end - window->res->start + 1;

Use resource_size() instead.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2018-05-16 20:32    [W:0.077 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site