lkml.org 
[lkml]   [2018]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver
From
Date
Hi Dan,

Thanks for the update.

On 05/15/2018 05:43 PM, Dan Murphy wrote:
> Introduce the device tree bindings for the lm3601x
> family of LED torch, flash and IR drivers.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v6 - Removed multiple led child nodes, fixed example to display micro ranges
> for corresponding child nodes and added led-sources to define the current driver -
> https://patchwork.kernel.org/patch/10392121/
>
> v5 - No changes - https://patchwork.kernel.org/patch/10391743/
> v4 - Added " " around "=", changed strobe to flash on label, removed "support and
> register" comment and change ir lable to ir:torch - See v2 patchworks for comments
> v3 - Removed wildcard compatible - https://patchwork.kernel.org/patch/10386241/
> v2 - No changes - https://patchwork.kernel.org/patch/10384587/
>
> .../devicetree/bindings/leds/leds-lm3601x.txt | 47 +++++++++++++++++++
> 1 file changed, 47 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3601x.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3601x.txt b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> new file mode 100644
> index 000000000000..27930a89e9a5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> @@ -0,0 +1,47 @@
> +* Texas Instruments - lm3601x Single-LED Flash Driver
> +
> +The LM3601X are ultra-small LED flash drivers that
> +provide a high level of adjustability.
> +
> +Required properties:
> + - compatible : Can be one of the following
> + "ti,lm36010"
> + "ti,lm36011"
> + - reg : I2C slave address
> + - #address-cells : 1
> + - #size-cells : 0
> +
> +Required child properties:
> + - reg : 0
> + - led-sources: 0 - Indicates a IR mode
> + 1 - Indicates a Torch (white LED) mode

You don't need led-sources at all. Please use reg as in
the previous version. led-sources is useful for describing
more complex arrangements. Here reg will do.

> +
> +Required properties for flash LED child nodes:
> + See Documentation/devicetree/bindings/leds/common.txt
> + - flash-max-microamp : Range from 11mA -> 1.5A
> + - flash-max-timeout-us : Range from 40ms -> 1600ms
> + - led-max-microamp : Range from 2.4mA -> 376mA

Please give also a step in the format like below
(taken from max77693):

Valid values: 62500 - 1000000, step by 62500 (rounded down)


> +
> +Optional child properties:
> + - label : see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example:
> +led-controller@64 {
> + compatible = "ti,lm36010";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x64>;
> +
> + led@0 {
> + reg = <0>;
> + label = "white:torch";
> + led-max-microamp = <376000>;
> + flash-max-microamp = <1500000>;
> + flash-max-timeout-us = <1600000>;
> + led-sources = <1>;
> + };
> +}
> +
> +For more product information please see the links below:
> +http://www.ti.com/product/LM36010
> +http://www.ti.com/product/LM36011
>

--
Best regards,
Jacek Anaszewski

\
 
 \ /
  Last update: 2018-05-15 23:16    [W:0.151 / U:4.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site