lkml.org 
[lkml]   [2018]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v9 1/2] arch/*: Add CONFIG_ARCH_HAVE_CMPXCHG64
Date
On Tue, 2018-05-15 at 12:54 +1000, Michael Ellerman wrote:
> Bart Van Assche <bart.vanassche@wdc.com> writes:
> >
> > + -----------------------
> > + | arch |status|
> > + -----------------------
> > + | alpha: | ok |
> > + | arc: | TODO |
> > + | arm: |!thumb|
> > + | arm64: | ok |
> > + | c6x: | TODO |
> > + | h8300: | TODO |
> > + | hexagon: | TODO |
> > + | ia64: | ok |
> > + | m68k: | ok |
> > + | microblaze: | TODO |
> > + | mips: |64-bit|
> > + | nios2: | TODO |
> > + | openrisc: | TODO |
> > + | parisc: | ok |
> > + | powerpc: |64-bit|
>
> I think that is correct for powerpc, we don't have a 32-bit
> implementation and there's no fallback it seems.
>
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -150,6 +150,7 @@ config PPC
> > select ARCH_HAS_UBSAN_SANITIZE_ALL
> > select ARCH_HAS_ZONE_DEVICE if PPC_BOOK3S_64
> > select ARCH_HAVE_NMI_SAFE_CMPXCHG
> > + select ARCH_HAVE_CMPXCHG64
>
> So shouldn't this should be:
>
> + select ARCH_HAVE_CMPXCHG64 if PPC64
>
> And it should be sorted alphabetically, ie. above the previous NMI entry.

Hello Michael,

Thanks, I will make these changes.

Bart.




\
 
 \ /
  Last update: 2018-05-15 17:15    [W:0.155 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site