lkml.org 
[lkml]   [2018]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] phy: qcom-qusb2: Quiet -EPROBE_DEFER from qusb2_phy_probe()
From
Date
Hi Doug,


On 5/15/2018 4:12 AM, Douglas Anderson wrote:
> The -EPROBE_DEFER virus demands special case code to avoid printing
> error messages when the error is only -EPROBE_DEFER. Spread the virus
> to a new host: qusb2_phy_probe(). Specifically handle when our
> regulators might not be ready yet.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> index 94afeac1a19e..26354618fd45 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> @@ -711,7 +711,9 @@ static int qusb2_phy_probe(struct platform_device *pdev)
>
> ret = devm_regulator_bulk_get(dev, num, qphy->vregs);
> if (ret) {
> - dev_err(dev, "failed to get regulator supplies\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "failed to get regulator supplies: %d\n",
> + ret);
> return ret;
> }
>
Thanks for the patch.
Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>

regards
Vivek

\
 
 \ /
  Last update: 2018-05-15 09:03    [W:0.094 / U:1.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site