lkml.org 
[lkml]   [2018]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] x86/asm: Pad assembly functions with INT3 instructions
On Tue, May 15, 2018 at 3:58 PM Alexey Dobriyan <adobriyan@gmail.com> wrote:
> jb resume_kernel # not returning to v8086
or userspace
> -
> -ENTRY(resume_userspace)

I went back in history, and we used to have multiple "jmp resume_userspace"
including even the vm86.c code (in a different file) doing that, so there
*used* to be a reason for this being a global symbol (and yes, we had a
fall-through to that global symbol even in those days).

That said, I also look at "resume_kernel". There's no reason to make that
globally visible afaik. It looks local to entry_32.S, and should look like
restore_all rather than resume_userspace.

So we probably should remove the ENTRY() for that too, and just make it be

ALIGN
resume_kernel:

instead?

I guess the reason for removing that other ENTRY() is different from this
case, though..

Linus

\
 
 \ /
  Last update: 2018-05-16 01:30    [W:0.763 / U:5.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site