lkml.org 
[lkml]   [2018]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [lkp-robot] [x86/asm] 51bad67ffb: int3:#[##]
On Tue, May 15, 2018 at 03:28:19PM -0700, Linus Torvalds wrote:
> On Tue, May 15, 2018 at 3:22 PM Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> > The padding isn't needed there, and the resume_userspace symbol is never
> > used, so wouldn't this fix it?
>
> This looks like the correct fix for this case, but are we sure there aren't
> other cases where we have this same "fall through to an ENTRY" case?
>
> Because we've definitely had that kind of code before too - sometimes
> simply because we want profiles and oopses to show which "part" of the asm
> we're faulting in (that could be the case here too).

Glancing through the 32-bit and 64-bit entry code, I didn't see any more
cases. At least it will fail loudly if any such cases do still exist.

--
Josh

\
 
 \ /
  Last update: 2018-05-16 00:44    [W:0.119 / U:1.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site