lkml.org 
[lkml]   [2018]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/10] autofs4 - merge auto_fs.h and auto_fs4.h
From
Date
On 14/05/18 11:15, Al Viro wrote:
> On Mon, May 14, 2018 at 11:03:50AM +0800, Ian Kent wrote:
>> The autofs module has long since been removed so there's no need to have
>> two separate include files for autofs.
>
> Umm... Why does fs/compat_ioctl.c need either include, actually?
>
>> --- a/fs/compat_ioctl.c
>> +++ b/fs/compat_ioctl.c
>> @@ -39,7 +39,6 @@
>> #include <linux/if_pppox.h>
>> #include <linux/mtio.h>
>> #include <linux/auto_fs.h>
>> -#include <linux/auto_fs4.h>
>> #include <linux/tty.h>
>> #include <linux/vt_kern.h>
>> #include <linux/fb.h>
>
> AFAICS, we can just delete both. Matter of fact, a *lot* of those includes are
> pointless nowadays...
>

OK, I'll have a look at that and post a follow up patch.

Thanks for having a look at these Al.

\
 
 \ /
  Last update: 2018-05-14 07:49    [W:0.075 / U:3.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site