lkml.org 
[lkml]   [2018]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v9 1/2] arch/*: Add CONFIG_ARCH_HAVE_CMPXCHG64
Date
Hi Bart,

Bart Van Assche <bart.vanassche@wdc.com> writes:
>
...
> diff --git a/Documentation/features/locking/cmpxchg64/arch-support.txt b/Documentation/features/locking/cmpxchg64/arch-support.txt
> new file mode 100644
> index 000000000000..65b3290ce5d5
> --- /dev/null
> +++ b/Documentation/features/locking/cmpxchg64/arch-support.txt
> @@ -0,0 +1,31 @@
> +#
> +# Feature name: cmpxchg64
> +# Kconfig: ARCH_HAVE_CMPXCHG64
> +# description: arch supports the cmpxchg64() API
> +#
> + -----------------------
> + | arch |status|
> + -----------------------
> + | alpha: | ok |
> + | arc: | TODO |
> + | arm: |!thumb|
> + | arm64: | ok |
> + | c6x: | TODO |
> + | h8300: | TODO |
> + | hexagon: | TODO |
> + | ia64: | ok |
> + | m68k: | ok |
> + | microblaze: | TODO |
> + | mips: |64-bit|
> + | nios2: | TODO |
> + | openrisc: | TODO |
> + | parisc: | ok |
> + | powerpc: |64-bit|

I think that is correct for powerpc, we don't have a 32-bit
implementation and there's no fallback it seems.

> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -150,6 +150,7 @@ config PPC
> select ARCH_HAS_UBSAN_SANITIZE_ALL
> select ARCH_HAS_ZONE_DEVICE if PPC_BOOK3S_64
> select ARCH_HAVE_NMI_SAFE_CMPXCHG
> + select ARCH_HAVE_CMPXCHG64

So shouldn't this should be:

+ select ARCH_HAVE_CMPXCHG64 if PPC64

And it should be sorted alphabetically, ie. above the previous NMI entry.

cheers

\
 
 \ /
  Last update: 2018-05-15 04:55    [W:0.129 / U:2.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site