lkml.org 
[lkml]   [2018]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 12/12] of/platform: make the OF code aware of early platform drivers
Hi Bartosz,

On Fri, May 11, 2018 at 6:20 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Check the relevant flag in the device node and skip the allocation
> part for devices that were populated early.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Thanks for your patch!

> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c

> @@ -196,9 +197,17 @@ static struct platform_device *of_platform_device_create_pdata(
> of_node_test_and_set_flag(np, OF_POPULATED))
> return NULL;
>
> - dev = of_device_alloc(np, bus_id, parent);
> - if (!dev)
> - goto err_clear_flag;
> + if (of_node_check_flag(np, OF_POPULATED_EARLY)) {
> + dev = of_early_to_platform_device(np);
> + if (IS_ERR(dev))
> + goto err_clear_flag;
> +
> + of_device_init(dev, np, bus_id, parent);
> + } else {
> + dev = of_device_alloc(np, bus_id, parent);
> + if (!dev)
> + goto err_clear_flag;
> + }

The above may become cleaner if:
1. of_early_to_platform_device() would return NULL instead -ENOENT,
2. of_device_alloc() would be split in alloc and init phases, too.

Then you can do:

dev = of_node_check_flag(np, OF_POPULATED_EARLY)
? of_early_to_platform_device(np)
: __of_device_alloc(np, bus_id, parent);
if (!dev)
goto err_clear_flag;

of_device_init(dev, np, bus_id, parent);

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2018-05-14 23:33    [W:0.095 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site