lkml.org 
[lkml]   [2018]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/5] media: docs: selection: fix typos
From
Date
Hi Luca,

My apologies for the long delay in reviewing this.

It all looks very good and if you can post a v2 with these small issues
fixed, then I'll merge it for 4.18.

Regards,

Hans

On 05/13/2018 11:13 AM, Hans Verkuil wrote:
> On 04/03/2018 11:15 PM, Luca Ceresoli wrote:
>
> Please add a commit message here. Yes, it can be as simple as 'Fixed typos in the
> selection documentation.'
>
> Regards,
>
> Hans
>
>> Cc: Hans Verkuil <hverkuil@xs4all.nl>
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>> ---
>> Documentation/media/uapi/v4l/selection-api-004.rst | 2 +-
>> Documentation/media/uapi/v4l/selection.svg | 4 ++--
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/media/uapi/v4l/selection-api-004.rst b/Documentation/media/uapi/v4l/selection-api-004.rst
>> index d782cd5b2117..0a4ddc2d71db 100644
>> --- a/Documentation/media/uapi/v4l/selection-api-004.rst
>> +++ b/Documentation/media/uapi/v4l/selection-api-004.rst
>> @@ -41,7 +41,7 @@ The driver may further adjust the requested size and/or position
>> according to hardware limitations.
>>
>> Each capture device has a default source rectangle, given by the
>> -``V4L2_SEL_TGT_CROP_DEFAULT`` target. This rectangle shall over what the
>> +``V4L2_SEL_TGT_CROP_DEFAULT`` target. This rectangle shall cover what the
>> driver writer considers the complete picture. Drivers shall set the
>> active crop rectangle to the default when the driver is first loaded,
>> but not later.
>> diff --git a/Documentation/media/uapi/v4l/selection.svg b/Documentation/media/uapi/v4l/selection.svg
>> index a93e3b59786d..911062bd2844 100644
>> --- a/Documentation/media/uapi/v4l/selection.svg
>> +++ b/Documentation/media/uapi/v4l/selection.svg
>> @@ -1128,11 +1128,11 @@
>> </text>
>> </g>
>> <text transform="matrix(.96106 0 0 1.0405 48.571 195.53)" x="2438.062" y="1368.429" enable-background="new" font-size="50" style="line-height:125%">
>> - <tspan x="2438.062" y="1368.429">COMPOSE_BONDS</tspan>
>> + <tspan x="2438.062" y="1368.429">COMPOSE_BOUNDS</tspan>
>> </text>
>> <g font-size="40">
>> <text transform="translate(48.571 195.53)" x="8.082" y="1438.896" enable-background="new" style="line-height:125%">
>> - <tspan x="8.082" y="1438.896" font-size="50">CROP_BONDS</tspan>
>> + <tspan x="8.082" y="1438.896" font-size="50">CROP_BOUNDS</tspan>
>> </text>
>> <text transform="translate(48.571 195.53)" x="1455.443" y="-26.808" enable-background="new" style="line-height:125%">
>> <tspan x="1455.443" y="-26.808" font-size="50">overscan area</tspan>
>>
>

\
 
 \ /
  Last update: 2018-05-13 11:20    [W:0.137 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site