[lkml]   [2018]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V2 1/2] Revert "ssb: Prevent build of PCI host features in module"
On 11 May 2018 at 12:13, Kalle Valo <> wrote:
> Rafał Miłecki <> writes:
>> On 11 May 2018 at 11:17, Rafał Miłecki <> wrote:
>>> From: Rafał Miłecki <>
>>> This reverts commit 882164a4a928bcaa53280940436ca476e6b1db8e.
>>> Above commit added "SSB = y" dependency to the wrong symbol
>>> selected when needed. PCI core driver for core running in clienthost
>>> mode is important for bus initialization. It's perfectly valid scenario
>>> to have ssb built as module and use it with buses on PCI cards.
>>> This fixes regression that affected all *module* users with PCI cards.
>>> Bugzilla:
>>> Signed-off-by: Rafał Miłecki <>
>> As these patches fix regression/build error, I believe both should get
>> into 4.17.
> How much confidence do we have that we don't need to end up reverting
> patch 2 as well? I rather be pushing patch 2 to 4.18 so that there's
> more time for testing and waiting for feedback.

Solution from 2/2 seems pretty obvious.

1) Enabling SSB_PCICORE_HOSTMODE compiles code that requires
non-exported symbols. Requiring "SSB = y" seems pretty obvious.
2) As pointed in another e-mail bcma has pretty identical solution
that seems to be working well, see commit 79ca239a68f8f ("bcma:
Prevent build of PCI host features in module").

That's just my opinion though, I shared since you asked.

If you prefer to queue that for 4.18, I'm OK. After all:
1) This problem affects MIPS arch only
2) It can be fixed by not selecting BCMA_DRIVER_PCI_HOSTMODE for SSB = m


 \ /
  Last update: 2018-05-11 12:26    [W:0.068 / U:2.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site