lkml.org 
[lkml]   [2018]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 7/9] trace_uprobe/sdt: Fix multiple update of same reference counter
From
Date
Hi Oleg,

On 04/09/2018 06:47 PM, Oleg Nesterov wrote:
> On 04/04, Ravi Bangoria wrote:
>> +static void sdt_add_mm_list(struct trace_uprobe *tu, struct mm_struct *mm)
>> +{
>> + struct mmu_notifier *mn;
>> + struct sdt_mm_list *sml = kzalloc(sizeof(*sml), GFP_KERNEL);
>> +
>> + if (!sml)
>> + return;
>> + sml->mm = mm;
>> + list_add(&(sml->list), &(tu->sml.list));
>> +
>> + /* Register mmu_notifier for this mm. */
>> + mn = kzalloc(sizeof(*mn), GFP_KERNEL);
>> + if (!mn)
>> + return;
>> +
>> + mn->ops = &sdt_mmu_notifier_ops;
>> + __mmu_notifier_register(mn, mm);
>> +}
> I didn't read this version yet, just one question...
>
> So now it depends on CONFIG_MMU_NOTIFIER, yes? I do not see any changes in Kconfig
> files, this doesn't look right...

Yes, you are write. I'll make CONFIG_UPROBE_EVENTS dependent on
CONFIG_MMU_NOTIFIER.

Thanks,
Ravi

\
 
 \ /
  Last update: 2018-04-09 15:32    [W:0.185 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site