lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/20] afs: Implement @sys substitution handling
From
Date


On 6.04.2018 11:13, David Howells wrote:
> Al Viro <viro@ZenIV.linux.org.uk> wrote:
>
>> lookup_one_len() seriously depends upon exclusive lock
>
> In the code it says:
>
> WARN_ON_ONCE(!inode_is_locked(base->d_inode));
>
> which checks i_rwsem, but in the banner comment it says:
>
> * The caller must hold base->i_mutex.
>
> is one of these wrong?

Before the switch to i_rwsem, inodes had only i_mutex, so in fact the
comment is likely stale.

>
> David
>

\
 
 \ /
  Last update: 2018-04-06 19:55    [W:0.105 / U:2.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site