lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 05/20] afs: Implement @sys substitution handling
Date
Al Viro <viro@ZenIV.linux.org.uk> wrote:

> > +static struct dentry *afs_lookup_atsys(struct inode *dir, struct dentry *dentry,
> > + struct key *key)
> > +{
>
> > + ret = lookup_one_len(buf, parent, len);
>
> Er... Parent is locked only shared here and lookup_one_len() seriously
> depends upon exclusive lock. As it is, race with lookup of the full name
> will mess the things up very badly.

How should it be done? Do I have to use d_alloc_parallel(), analogous to
lookup_slow() without taking the rwsem again?

David

PS: Can you stick a banner comment on d_alloc_parallel() describing it?

\
 
 \ /
  Last update: 2018-04-06 10:10    [W:0.189 / U:1.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site