lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: greybus: Fix warning to limit chars per line
On Fri, Apr 06, 2018 at 10:52:17AM +0530, Viresh Kumar wrote:
> On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer <mgreer@animalcreek.com> wrote:
> > On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote:
> >> Wrap comment to fix warning "prefer a maximum 75 chars per line"
> >>
> >> Signed-off-by: Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>
> >> ---
> >> drivers/staging/greybus/audio_codec.h | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> >> index a1d5440..01838d9 100644
> >> --- a/drivers/staging/greybus/audio_codec.h
> >> +++ b/drivers/staging/greybus/audio_codec.h
> >> @@ -23,7 +23,9 @@ enum {
> >> NUM_CODEC_DAIS,
> >> };
> >>
> >> -/* device_type should be same as defined in audio.h (Android media layer) */
> >> +/* device_type should be same as defined in audio.h
>
> This isn't the right way to write a multi-line comment. It should be like:
>
> /*
> * XXXX
> * XXXX
> */

Ugh, yeah, you're right. I must have been sleeping.

Mark
--

\
 
 \ /
  Last update: 2018-04-06 18:01    [W:0.065 / U:3.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site