lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: greybus: Fix warning to limit chars per line
From
Date
Hi,

Thanks for reviewing the patch.


On Friday 06 April 2018 10:52 AM, Viresh Kumar wrote:
> On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer <mgreer@animalcreek.com> wrote:
>> On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote:
>>> Wrap comment to fix warning "prefer a maximum 75 chars per line"
>>>
>>> Signed-off-by: Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>
>>> ---
>>> drivers/staging/greybus/audio_codec.h | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
>>> index a1d5440..01838d9 100644
>>> --- a/drivers/staging/greybus/audio_codec.h
>>> +++ b/drivers/staging/greybus/audio_codec.h
>>> @@ -23,7 +23,9 @@ enum {
>>> NUM_CODEC_DAIS,
>>> };
>>>
>>> -/* device_type should be same as defined in audio.h (Android media layer) */
>>> +/* device_type should be same as defined in audio.h
> This isn't the right way to write a multi-line comment. It should be like:
>
> /*
> * XXXX
> * XXXX
> */
I sent in an updated patchset. Though I forgot to add
viresh.kumar@linaro.org to "To" in mail. I tried to follow instructions
described on https://kernelnewbies.org/FirstKernelPatch for updating my
patch. Do you think I followed the instructions correctly? I was
thinking may be I need to update the already sent patch by adding *new
commit* to my already existing commit on that git branch, but instead I
tried to do what I understood from the website I mentioned above.
>>> + * (Android media layer)
>>> + */
>>> enum {
>>> GBAUDIO_DEVICE_NONE = 0x0,
>>> /* reserved bits */
>>> --
>>> 1.9.1
>> Hi Gaurav.
>>
>> Thank you for the patch, it looks fine to me.
>>
>> Reviewed-by: Mark Greer <mgreer@animalcreek.com>

--
Gaurav Dhingra
(sent from Thunderbird email client)

\
 
 \ /
  Last update: 2018-04-06 12:18    [W:0.067 / U:2.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site