lkml.org 
[lkml]   [2018]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/10] locking/qspinlock: Elide back-to-back RELEASE operations with smp_wmb()
On Thu, Apr 05, 2018 at 05:59:07PM +0100, Will Deacon wrote:
> @@ -340,12 +341,17 @@ void queued_spin_lock_slowpath(struct qspinlock *lock, u32 val)
> goto release;
>
> /*
> + * Ensure that the initialisation of @node is complete before we
> + * publish the updated tail and potentially link @node into the
> + * waitqueue.
> + */
> + smp_wmb();

Maybe an explicit note to where the matching barrier lives..

\
 
 \ /
  Last update: 2018-04-05 19:28    [W:0.211 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site