lkml.org 
[lkml]   [2018]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched/rt: Fix rq->clock_update_flags < RQCF_ACT_SKIP warning

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, Apr 04, 2018 at 09:15:39AM -0700, Davidlohr Bueso wrote:
> > On Mon, 02 Apr 2018, Davidlohr Bueso wrote:
> >
> > > The case for the rt task throttling (which this workload also hits) can be ignored in
> > > that the skip_update call is actually bogus and quite the contrary (the request bits
> > > are removed/reverted).
> >
> > While at it, how about this trivial patch?
> >
> > ----8<--------------------------------------------------------
> > [PATCH 2/1] sched: Simplify helpers for rq clock update skip requests
> >
> > By renaming the functions we can get rid of the skip parameter
> > and have better code redability. It makes zero sense to have
> > things such as:
> >
> > rq_clock_skip_update(rq, false)
> >
> > When the skip request is in fact not going to happen. Ever. Rename
> > things such that we end up with:
> >
> > rq_clock_skip_update(rq)
> > rq_clock_cancel_skipupdate(rq)
> >
> > Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
>
> Works for me :-)
>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

I have applied both patches, thanks guys!

Ingo

\
 
 \ /
  Last update: 2018-04-05 09:21    [W:0.069 / U:2.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site