lkml.org 
[lkml]   [2018]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 06/12] fscache: Detect multiple relinquishment of a cookie
On Wed, Apr 4, 2018 at 3:07 PM, David Howells <dhowells@redhat.com> wrote:
> Report if an fscache cookie is relinquished multiple times by the netfs.
>
> - set_bit(FSCACHE_COOKIE_RELINQUISHED, &cookie->flags);
> + if (test_and_set_bit(FSCACHE_COOKIE_RELINQUISHED, &cookie->flags))
> + BUG();

Ugh. Please try to avoid adding BUG() calls for reporting. They can
often cause the machine to be basically dead.

This one seem fairly ok, simply because it looks like the only caller
doesn't really hold a lot of locks (the superblock s_umount lock, but
that may be all).

So I'll pull this change, I just wanted people to realize that if this
is a "help make sure we notice if things go wrong", then
"WARN_ON_ONCE()" or something is usually a better choice than
"potentially kill the machine and make it harder to actually see the
error".

Linus

\
 
 \ /
  Last update: 2018-04-05 00:53    [W:0.147 / U:5.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site