lkml.org 
[lkml]   [2018]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] tracing, printk: Force no hashing when trace_printk() is used
On Wed, 4 Apr 2018 12:04:42 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:


>
> So at the *very* least this would need to be percpu logic, but even
> that is honestly broken since an NMI might come in and want to printk
> too.
>
> Why don't you just use %px? That avoids all of these hacks.

Just need to remember to do that. I guess with time it will become
second nature.

>
> So NAK on this stupid "enable and disable hashing that is
> fundamentally broken" approach.
>

OK. I'll save the change locally, and add it while debugging kernels.
ktest can do that for me ;-)

-- Steve

\
 
 \ /
  Last update: 2018-04-04 21:31    [W:0.039 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site