lkml.org 
[lkml]   [2018]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC][PATCH] tracing, printk: Force no hashing when trace_printk() is used
On Wed, Apr 4, 2018 at 12:49 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Apr 03, 2018 at 05:06:12PM -0400, Steven Rostedt wrote:
>> If you are concerned about attack surface, I could make it a bit more
>> difficult to tweak by malicious software. What about the patch below?
>> It would be much more difficult to modify this knob from an attack
>> vector.
>
> Not if you build using clang, because that doesn't support asm-goto and
> thus falls back to a simple runtime variable, which is exactly what Kees
> didn't want.

Nah, Clang will get asm-goto soon. I'm not worried about that. Besides
the "yay new target issue", I was concerned about Linus yelling about
seeing the knob added he specifically said he didn't want. :P

-Kees

--
Kees Cook
Pixel Security

\
 
 \ /
  Last update: 2018-04-04 18:27    [W:0.053 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site