lkml.org 
[lkml]   [2018]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] x86: olpc: fix inconsistent MFD_CS5535 configuration
On Wed, Apr 4, 2018 at 4:09 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 4 Apr 2018, Arnd Bergmann wrote:
>
>> This Kconfig warning appeared after a fix to the Kconfig validation.
>> The GPIO_CS5535 driver depends on the MFD_CS5535 driver, but the former
>> is selected in places where the latter is not:
>
> And why does GPIO_CS5535 not select MFD_CS5535 if it depends on it?

I tried that first and ran into circular dependencies: OLPC_XO1_SCI selects
GPIO_CS5535 but depends on OLPC_XO1_PM, which in turn depends on
MFD_CS5535.

What we could perhaps do is to make OLPC_XO1_PM select MFD_CS5535
instead of depending on it, that way it would be forced to be built-in here.
I can run a few more builds on that version if you prefer it.
Generally speaking,
turning 'depends on' into 'select' tends to cause more problems with circular
dependencies than doing it the other way round.

Arnd

\
 
 \ /
  Last update: 2018-04-04 16:30    [W:0.039 / U:8.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site