lkml.org 
[lkml]   [2018]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 07/10] powerpc: Switch to generic local_softirq_pending() implementation
Date
Frederic Weisbecker <frederic@kernel.org> writes:

> Remove the ad-hoc implementation, the generic code now allows us not to
> reinvent the wheel.
>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: James E.J. Bottomley <jejb@parisc-linux.org>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> ---
> arch/powerpc/include/asm/hardirq.h | 7 -------
> 1 file changed, 7 deletions(-)

If I'm reading it right the generic code implements exactly the same as
what we have now, so:

Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)

cheers

> diff --git a/arch/powerpc/include/asm/hardirq.h b/arch/powerpc/include/asm/hardirq.h
> index 5986d47..383f628 100644
> --- a/arch/powerpc/include/asm/hardirq.h
> +++ b/arch/powerpc/include/asm/hardirq.h
> @@ -25,15 +25,8 @@ typedef struct {
> DECLARE_PER_CPU_SHARED_ALIGNED(irq_cpustat_t, irq_stat);
>
> #define __ARCH_IRQ_STAT
> -
> -#define local_softirq_pending() __this_cpu_read(irq_stat.__softirq_pending)
> -
> -#define __ARCH_SET_SOFTIRQ_PENDING
> #define __ARCH_IRQ_EXIT_IRQS_DISABLED
>
> -#define set_softirq_pending(x) __this_cpu_write(irq_stat.__softirq_pending, (x))
> -#define or_softirq_pending(x) __this_cpu_or(irq_stat.__softirq_pending, (x))
> -
> static inline void ack_bad_irq(unsigned int irq)
> {
> printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq);
> --
> 2.7.4

\
 
 \ /
  Last update: 2018-04-04 12:21    [W:0.068 / U:2.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site