lkml.org 
[lkml]   [2018]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 char-misc 1/1] x86/hyperv: Add interrupt handler annotations
On Tue, Apr 03, 2018 at 01:59:08PM -0700, mhkelley58@gmail.com wrote:
> From: Michael Kelley <mikelley@microsoft.com>
>
> Add standard interrupt handler annotations to
> hyperv_vector_handler().
>
> Signed-off-by: Michael Kelley <mikelley@microsoft.com>
> ---
> Changes in v2:
> * Fixed From: line
> ---
> arch/x86/kernel/cpu/mshyperv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> index 4488cf0..20f6849 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -41,7 +41,7 @@ static void (*hv_stimer0_handler)(void);
> static void (*hv_kexec_handler)(void);
> static void (*hv_crash_handler)(struct pt_regs *regs);
>
> -void hyperv_vector_handler(struct pt_regs *regs)
> +__visible void __irq_entry hyperv_vector_handler(struct pt_regs *regs)

What bug does this solve? What is wrong with the existing markings?
What does __visible and __irq_entry give us that we don't already have
and we need?

Are you really using LTO that requires this marking to prevent the code
from being removed?

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-04-04 10:16    [W:0.075 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site