lkml.org 
[lkml]   [2018]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [net-next] ipv6: sr: Extract the right key values for "seg6_make_flowlabel"
On Fri, 27 Apr 2018 13:59:07 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:

> From: Ahmed Abdelsalam <amsalam20@gmail.com>
> Date: Thu, 26 Apr 2018 16:11:11 +0200
>
> > @@ -119,6 +119,9 @@ int seg6_do_srh_encap(struct sk_buff *skb, struct ipv6_sr_hdr *osrh, int proto)
> > int hdrlen, tot_len, err;
> > __be32 flowlabel;
> >
> > + inner_hdr = ipv6_hdr(skb);
>
> You have to make this assignment after, not before, the skb_cow_header()
> call. Otherwise this point can be pointing to freed up memory.

Ok!
I fixed and sent you a v2 of the patch.

--
Ahmed Abdelsalam <amsalam20@gmail.com>

\
 
 \ /
  Last update: 2018-04-28 12:20    [W:0.046 / U:4.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site