[lkml]   [2018]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mm: don't show nr_indirectly_reclaimable in /proc/vmstat
On 04/26/2018 11:55 PM, David Rientjes wrote:
> On Thu, 26 Apr 2018, Michal Hocko wrote:
>>> Don't show nr_indirectly_reclaimable in /proc/vmstat,
>>> because there is no need in exporting this vm counter
>>> to the userspace, and some changes are expected
>>> in reclaimable object accounting, which can alter
>>> this counter.
>>> Signed-off-by: Roman Gushchin <>
>>> Cc: Vlastimil Babka <>
>>> Cc: Matthew Wilcox <>
>>> Cc: Andrew Morton <>
>>> Cc: Alexander Viro <>
>>> Cc: Michal Hocko <>
>>> Cc: Johannes Weiner <>
>> This is quite a hack. I would much rather revert the counter and fixed
>> it the way Vlastimil has proposed. But if there is a strong opposition
>> to the revert then this is probably the simples thing to do. Therefore
> Implementing this counter as a vmstat doesn't make much sense based on how
> it's used. Do you have a link to what Vlastimil proposed? I haven't seen
> mention of alternative ideas.

It was in the original thread, see e.g.

However it will take some time to get that in mainline, and meanwhile
the current implementation does prevent a DOS. So I doubt it can be
fully reverted - as a compromise I just didn't want the counter to
become ABI. TBH though, other people at LSF/MM didn't seem concerned
that /proc/vmstat is an ABI that we can't change (i.e. counters have
been presumably removed in the past already).

 \ /
  Last update: 2018-04-27 11:17    [W:0.055 / U:22.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site