lkml.org 
[lkml]   [2018]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> handler already checks if there is an actual IRQ pending and returns
> IRQ_NONE otherwise.

hmmm what are we trying to fix here? Is your device on a shared line or not?

>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> Changes from v1:
> - Added Lars' Acked-by
> - Dropped patch [1/2] and changed accordingly
> ---
> drivers/dma/dma-axi-dmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 2419fe524daa..15b2453d2647 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
> if (ret)
> goto err_unregister_device;
>
> - ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
> + ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
> dev_name(&pdev->dev), dmac);
> if (ret)
> goto err_unregister_of;
> --
> 2.17.0
>

--
~Vinod

\
 
 \ /
  Last update: 2018-04-27 07:07    [W:0.062 / U:1.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site