lkml.org 
[lkml]   [2018]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments
On Wed, Apr 25, 2018 at 11:12:47AM -0700, kys@linuxonhyperv.com wrote:
> +/*
> + * IPI implementation on Hyper-V.
> + */
> +
> +static int __send_ipi_mask(const struct cpumask *mask, int vector)
> +{
> + int cur_cpu, vcpu;
> + struct ipi_arg_non_ex **arg;
> + struct ipi_arg_non_ex *ipi_arg;
> + int ret = 1;

Not specifically related to this patch, but hv code sometimes returns 1
on error or U64_MAX. It's slightly magical. Maybe
HV_STATUS_INVALID_HYPERCALL_INPUT (3) would be more appropriate? Or we
could make a new more generic error code:

#define HV_STATUS_INVALID 1

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-04-26 23:33    [W:0.179 / U:5.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site