lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 0/2] tty/nozomi: general module cleanup
On Tue, Apr 24, 2018 at 07:48:02PM -1000, Joey Pabalinas wrote:
> The nozomi module has a few sections which could use a bit of cleanup;
> both style and clarity could be improved while maintaining equivalent
> semantics.
>
> Cleanup messy portions of the module code while preserving existing
> behavior by:
>
> - Replacing constructs like `len__ > TMP_BUF_MAX ? TMP_BUF_MAX : len__`
> with `min_t(u32, len__, TMP_BUF_MAX)` and function calls like
> snprintf(tbuf, ..., "%s", ...). with strscpy(tbuf, ..., ...).
> - Correct inconsistently indented lines and extraneous whitespace.
>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Jiri Slaby <jslaby@suse.cz>
>
> Joey Pabalinas (2):
> tty/nozomi: cleanup DUMP() macro
> tty/nozomi: fix inconsistent indentation
>
> drivers/tty/nozomi.c | 100 +++++++++++++++++++++----------------------
> 1 file changed, 50 insertions(+), 50 deletions(-)

What changed between versions of this series?

greg k-h

\
 
 \ /
  Last update: 2018-04-25 08:05    [W:0.060 / U:5.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site