lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] drm: rcar-du: Use drm_dev_put
Date
Hi Vaishali,

Thank you for the patch.

On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote:
> As specified in drm_drv.c, drm_dev_unref is a compatibility alias
> for drm_dev_put and shouldn't be used in new code. So, use
> drm_dev_put instead.

This looks good to me. However, how about taking it one step further and mass-
patching all drivers to use drm_dev_put() ? We could then remove
drm_dev_unref() completely.

> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 05745e86d73e..418a80e6b2f4
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device *pdev)
> drm_kms_helper_poll_fini(ddev);
> drm_mode_config_cleanup(ddev);
>
> - drm_dev_unref(ddev);
> + drm_dev_put(ddev);
>
> return 0;
> }

--
Regards,

Laurent Pinchart



\
 
 \ /
  Last update: 2018-04-25 15:33    [W:0.056 / U:2.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site