lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [REVIEW][PATCH 04/17] signal/nds32: Use force_sig in unhandled_interruption and unhandled_exceptions
2018-04-20 9:03 GMT+08:00 Eric W. Biederman <ebiederm@xmission.com>:
> Neither unhandled_interrupt nor unhandled_exceptions fills in any of the
> siginfo fields whend sending SIGKILL. Further because it is SIGKILL
> even if all of the fields were filled out appropriately it would be impossible
> for the process to read any of the siginfo fields. So simplfy things and
> just use force_sig instead of force_sig_info.
>
> Fixes: 2923f5ea7738 ("nds32: Exception handling")
> Cc: Vincent Chen <vincentc@andestech.com>
> Cc: Greentime Hu <greentime@andestech.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> ---
> arch/nds32/kernel/traps.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/arch/nds32/kernel/traps.c b/arch/nds32/kernel/traps.c
> index 6e34eb9824a4..65961bf91d64 100644
> --- a/arch/nds32/kernel/traps.c
> +++ b/arch/nds32/kernel/traps.c
> @@ -318,29 +318,22 @@ void do_debug_trap(unsigned long entry, unsigned long addr,
>
> void unhandled_interruption(struct pt_regs *regs)
> {
> - siginfo_t si;
> pr_emerg("unhandled_interruption\n");
> show_regs(regs);
> if (!user_mode(regs))
> do_exit(SIGKILL);
> - si.si_signo = SIGKILL;
> - si.si_errno = 0;
> - force_sig_info(SIGKILL, &si, current);
> + force_sig(SIGKILL, current);
> }
>
> void unhandled_exceptions(unsigned long entry, unsigned long addr,
> unsigned long type, struct pt_regs *regs)
> {
> - siginfo_t si;
> pr_emerg("Unhandled Exception: entry: %lx addr:%lx itype:%lx\n", entry,
> addr, type);
> show_regs(regs);
> if (!user_mode(regs))
> do_exit(SIGKILL);
> - si.si_signo = SIGKILL;
> - si.si_errno = 0;
> - si.si_addr = (void *)addr;
> - force_sig_info(SIGKILL, &si, current);
> + force_sig(SIGKILL, current);
> }
>
> extern int do_page_fault(unsigned long entry, unsigned long addr,
> --
> 2.14.1
>

Acked-by Vincent Chen

\
 
 \ /
  Last update: 2018-04-25 14:15    [W:0.304 / U:19.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site