[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.14 043/183] iommu/exynos: Dont unconditionally steal bus ops
4.14-stable review patch.  If anyone has any objections, please let me know.


From: Robin Murphy <>

[ Upstream commit dc98b8480d8a68c2ce9aa28b9f0d714fd258bc0b ]

Removing the early device registration hook overlooked the fact that
it only ran conditionally on a compatible device being present in the
DT. With exynos_iommu_init() now running as an unconditional initcall,
problems arise on non-Exynos systems when other IOMMU drivers find
themselves unable to install their ops on the platform bus, or at worst
the Exynos ops get called with someone else's domain and all hell breaks

The global ops/cache setup could probably all now be triggered from the
first IOMMU probe, as with dma_dev assigment, but for the time being the
simplest fix is to resurrect the logic from commit a7b67cd5d9af
("iommu/exynos: Play nice in multi-platform builds") to explicitly check
the DT for the presence of an Exynos IOMMU before trying anything.

Fixes: 928055a01b3f ("iommu/exynos: Remove custom platform device registration code")
Signed-off-by: Robin Murphy <>
Acked-by: Marek Szyprowski <>
Signed-off-by: Joerg Roedel <>
Signed-off-by: Sasha Levin <>
Signed-off-by: Greg Kroah-Hartman <>
drivers/iommu/exynos-iommu.c | 7 +++++++
1 file changed, 7 insertions(+)

--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -1344,8 +1344,15 @@ static const struct iommu_ops exynos_iom

static int __init exynos_iommu_init(void)
+ struct device_node *np;
int ret;

+ np = of_find_matching_node(NULL, sysmmu_of_match);
+ if (!np)
+ return 0;
+ of_node_put(np);
lv2table_kmem_cache = kmem_cache_create("exynos-iommu-lv2table",
if (!lv2table_kmem_cache) {

 \ /
  Last update: 2018-04-25 13:28    [W:0.309 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site