lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dma-debug: Check scatterlist segments
Hi Robin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.17-rc2 next-20180424]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Robin-Murphy/dma-debug-Check-scatterlist-segments/20180425-070135
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sh

All warnings (new ones prefixed by >>):

In file included from arch/sh/include/asm/bug.h:112:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/sched/task_stack.h:9,
from lib/dma-debug.c:20:
lib/dma-debug.c: In function 'check_sg_segment':
>> lib/dma-debug.c:232:12: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
WARN(1, "%s %s: " format, \
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
>> lib/dma-debug.c:232:4: note: in expansion of macro 'WARN'
WARN(1, "%s %s: " format, \
^~~~
>> lib/dma-debug.c:1316:3: note: in expansion of macro 'err_printk'
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary [start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
^~~~~~~~~~
lib/dma-debug.c:1316:85: note: format string is defined here
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary [start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
~~~~~~^
%016x
In file included from arch/sh/include/asm/bug.h:112:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/sched/task_stack.h:9,
from lib/dma-debug.c:20:
lib/dma-debug.c:232:12: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
WARN(1, "%s %s: " format, \
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
>> lib/dma-debug.c:232:4: note: in expansion of macro 'WARN'
WARN(1, "%s %s: " format, \
^~~~
>> lib/dma-debug.c:1316:3: note: in expansion of macro 'err_printk'
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary [start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
^~~~~~~~~~
lib/dma-debug.c:1316:101: note: format string is defined here
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary [start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
~~~~~~^
%016x
In file included from arch/sh/include/asm/bug.h:112:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/sched/task_stack.h:9,
from lib/dma-debug.c:20:
lib/dma-debug.c:232:12: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
WARN(1, "%s %s: " format, \
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
>> lib/dma-debug.c:232:4: note: in expansion of macro 'WARN'
WARN(1, "%s %s: " format, \
^~~~
>> lib/dma-debug.c:1316:3: note: in expansion of macro 'err_printk'
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary [start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
^~~~~~~~~~
lib/dma-debug.c:1316:122: note: format string is defined here
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary [start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
~~~~~~^
%016x

vim +232 lib/dma-debug.c

2e507d84 Joerg Roedel 2009-05-22 227
6c132d1b David Woodhouse 2009-01-19 228 #define err_printk(dev, entry, format, arg...) do { \
2d62ece1 Joerg Roedel 2009-01-09 229 error_count += 1; \
2e507d84 Joerg Roedel 2009-05-22 230 if (driver_filter(dev) && \
2e507d84 Joerg Roedel 2009-05-22 231 (show_all_errors || show_num_errors > 0)) { \
2d62ece1 Joerg Roedel 2009-01-09 @232 WARN(1, "%s %s: " format, \
ec9c96ef Kyle McMartin 2009-08-19 233 dev ? dev_driver_string(dev) : "NULL", \
ec9c96ef Kyle McMartin 2009-08-19 234 dev ? dev_name(dev) : "NULL", ## arg); \
6c132d1b David Woodhouse 2009-01-19 235 dump_entry_trace(entry); \
2d62ece1 Joerg Roedel 2009-01-09 236 } \
2d62ece1 Joerg Roedel 2009-01-09 237 if (!show_all_errors && show_num_errors > 0) \
2d62ece1 Joerg Roedel 2009-01-09 238 show_num_errors -= 1; \
2d62ece1 Joerg Roedel 2009-01-09 239 } while (0);
2d62ece1 Joerg Roedel 2009-01-09 240

:::::: The code at line 232 was first introduced by commit
:::::: 2d62ece14fe04168a7d16688ddd2d17ac472268c dma-debug: add core checking functions

:::::: TO: Joerg Roedel <joerg.roedel@amd.com>
:::::: CC: Joerg Roedel <joerg.roedel@amd.com>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-04-25 06:53    [W:0.097 / U:7.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site