lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][v5] tools/power turbostat: if --iterations, print for specific count of iterations
On Mon, Apr 23, 2018 at 10:48:39AM +0200, Rafael J. Wysocki wrote:
> On Saturday, April 14, 2018 6:10:55 AM CEST Yu Chen wrote:
> > From: Chen Yu <yu.c.chen@intel.com>
> >
> > There's a use case during test to only print specific round of iterations
> > if --iterations is specified, for example, with this patch applied:
> >
> > turbostat -i 5 -r 4
> > will capture 4 samples with 5 seconds interval.
> >
> > Cc: Len Brown <lenb@kernel.org>
> > Cc: Rafael J Wysocki <rjw@rjwysocki.net>
> > Cc: Artem Bityutskiy <artem.bityutskiy@intel.com>
> > Cc: Doug Smythies <dsmythies@telus.net>
> > Cc: linux-pm@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
[cut]...
> > + if (iterations && (++done_iters >= iterations))
>
> The inner parens are not needed here (and similarly below).
>
> If you fix this little one, please feel free to add
>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> to the patch (FWIW).
>
OK, will do, thanks!
Yu

\
 
 \ /
  Last update: 2018-04-26 02:04    [W:0.047 / U:55.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site