lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] spi/bcm63xx-hspi: Enable the clock before calling clk_get_rate().
On Wed, Apr 25, 2018 at 06:49:06PM +0200, Stefan Potyra wrote:

> Additionally, prepare/enable the pll_clk before calling clk_get_rate()
> for the same reason.

I don't see this change in the code:

> struct clk *pll_clk = devm_clk_get(dev, "pll");
>
> - if (IS_ERR(pll_clk))
> - return PTR_ERR(pll_clk);
> + if (IS_ERR(pll_clk)) {
> + ret = PTR_ERR(pll_clk);
> + goto out_disable_clk;
> + }
> +
>
> rate = clk_get_rate(pll_clk);
> - if (!rate)
> - return -EINVAL;

Did you forget a git add?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-04-25 19:29    [W:0.046 / U:6.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site