lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 07/35] ovl: copy up file size as well
On Thu, Apr 12, 2018 at 05:07:58PM +0200, Miklos Szeredi wrote:
> Copy i_size of the underlying inode to the overlay inode in ovl_copyattr().
>
> This is in preparation for stacking I/O operations on overlay files.
>
> This patch shouldn't have any observable effect.
>
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
> ---
> fs/overlayfs/overlayfs.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/overlayfs/overlayfs.h b/fs/overlayfs/overlayfs.h
> index 265cb288417a..10f5f3bf9d96 100644
> --- a/fs/overlayfs/overlayfs.h
> +++ b/fs/overlayfs/overlayfs.h
> @@ -9,6 +9,7 @@
>
> #include <linux/kernel.h>
> #include <linux/uuid.h>
> +#include <linux/fs.h>
> #include "ovl_entry.h"
>
> enum ovl_path_type {
> @@ -355,6 +356,7 @@ static inline void ovl_copyattr(struct inode *from, struct inode *to)
> to->i_atime = from->i_atime;
> to->i_mtime = from->i_mtime;
> to->i_ctime = from->i_ctime;
> + i_size_write(to, i_size_read(from));
> }

With this change, is following comment in ovl_getattr() stale now.

/*
* We don't initialize inode->size, which just means that
* inode_newsize_ok() will always check against MAX_LFS_FILESIZE and not
* check for a swapfile (which this won't be anyway).
*/

Thanks
Vivek

\
 
 \ /
  Last update: 2018-04-24 20:11    [W:0.432 / U:6.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site