lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/4] ALSA: usb: UAC3 new features.
On Tue, 24 Apr 2018 19:24:41 +0200,
Jorge Sanjuan wrote:
>
> v2 fixes:
> - If/else statements braces style fixes.
> - Add wrapping function to mixer unit code.
> - Make connectors control kctl struct const.
> - Little endian to cpu conversion in several places.
> - Sing off and add Fixes tag to fixup commit.
> - Remove flex-array for a struct that is used statically.
>
> Now that the UAC3 patch [1] has made it to linux-next I have some extra
> features to make a UAC3 device fully work in Linux. Including Jack
> insertion control that I have put on top of this other patch [2] for
> UAC2. Also adding support for the UAC3 Mixer Unit which is most likely
> to appear in most headset type devices.

These patches look reasonable, I'm OK to merge. But I'll wait for
Ruslan's comments (or at best with test results).

> UAC3 devices also require to have a Basic Audio Device (BADD) in a separate
> config for which both Ruslan Bilovol and myself have submited different
> approaches[3][4] but I don't know what the final merge will be. Once there
> is official support for BADD, we'll need to test it with an actual UAC3
> device to confirm it all wokrs.

Could you guys try to get agreement which approach should we take?

I have no big preference. Currently Ruslan's patch series look
easier, just because its addition is a bit smaller, though.


Thanks!

Takashi

> All this features are tested with an actual UAC3 device that is still in
> development. For this patch series, only the legacy config (#1. UAC1/UAC2)
> and the UAC3 config have been tested. The BADD config is only tested using
> and updated verison of [4].
>
> [1]: https://patchwork.kernel.org/patch/10298179/
> [2]: https://patchwork.kernel.org/patch/10305847/
> [3]: https://patchwork.kernel.org/patch/10340851/
> [4]: https://www.spinics.net/lists/alsa-devel/msg71617.html
>
> Based on linux-next tag: next-20180420
>
> Jorge Sanjuan (3):
> ALSA: usb-audio: UAC3. Add support for mixer unit.
> ALSA: usb-audio: Use Class Specific EP for UAC3 devices.
> ALSA: usb-audio: UAC3 Add support for connector insertion.
>
> Michael Drake (1):
> ALSA: usb-audio: ADC3: Fix channel mapping conversion for ADC3.
>
> include/linux/usb/audio-v2.h | 7 ++
> include/linux/usb/audio-v3.h | 14 +++
> include/uapi/linux/usb/audio.h | 13 ++-
> sound/usb/mixer.c | 195 +++++++++++++++++++++++++++++++++++++----
> sound/usb/stream.c | 11 ++-
> 5 files changed, 217 insertions(+), 23 deletions(-)
>
> --
> 2.11.0
>
>

\
 
 \ /
  Last update: 2018-04-24 20:03    [W:0.328 / U:18.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site