lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCHv3 3/7] driver, misc: add Intel Stratix10 service layer driver
Date
From: Greg KH
> Sent: 23 April 2018 13:03
> On Tue, Mar 27, 2018 at 03:20:10PM -0500, richard.gong@linux.intel.com wrote:
> > +config INTEL_SERVICE
>
> Naming is hard, but this is a _very_ generic name, don't you agree?
>
> > + tristate "Intel Service Layer"
>
> As is this. Can you make this a bit more specific to what hardware is
> being controlled here?
>
> > +++ b/drivers/misc/intel-service.c
>
> Same for the file name, why not stratix10.c?
>
> or intel_svc.c? That makes it a _bit_ more generic. Well, not really,
> but it does hide the "genericness" a bit more, right?

It'll all be even worse if (when) Intel decide to sell Altera to
someone else.

David

\
 
 \ /
  Last update: 2018-04-24 13:24    [W:0.091 / U:5.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site