[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 01/22] dma-debug: move initialization to common code
On Fri, Apr 20, 2018 at 11:23:43AM +0100, Robin Murphy wrote:
>> -void dma_debug_init(u32 num_entries)
>> +static int dma_debug_init(void)
>> {
>> + u32 num_entries;
> Maybe initialise it to PREALLOC_DMA_DEBUG_ENTRIES?

We initialize it down in an if/else clause which seems a little more clear
to me, at the cost of two extra lines of code. But I suspect I should
just go a little further and merge the global req_entries and the local
num_entries into a single variable with a better name.

>> +core_initcall(dma_debug_init);
> I think it's worth noting that for most users this now happens much earlier
> than before. In general that's probably good (e.g. on arm64 it should
> prevent false-positives from the Arm SMMU drivers under ACPI), and I can't
> imagine it's high-risk, but it is a behaviour change.

I'll mention this in the changelog, thanks!

 \ /
  Last update: 2018-04-24 09:34    [W:0.318 / U:3.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site