lkml.org 
[lkml]   [2018]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] blk-mq: Fix request handover from timeout path to normal execution
From
Date
On 04/02/18 12:01, Tejun Heo wrote:
> + * As nothing prevents from completion happening while
> + * ->aborted_gstate is set, this may lead to ignored completions
> + * and further spurious timeouts.
> + */
> + if (rq->rq_flags & RQF_MQ_TIMEOUT_RESET)
> + blk_mq_rq_update_aborted_gstate(rq, 0);

Hello Tejun,

Since this patch fixes one race but introduces another race, is this
patch really an improvement?

Thanks,

Bart.

\
 
 \ /
  Last update: 2018-04-02 23:09    [W:0.059 / U:1.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site