lkml.org 
[lkml]   [2018]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 00/12] PCI endpoint 64-bit BAR fixes
On Thu, Mar 29, 2018 at 02:52:56PM +0100, Gustavo Pimentel wrote:
> Hi Niklas,
>
> On 28/03/2018 12:50, Niklas Cassel wrote:
> > PCI endpoint fixes to improve the way 64-bit BARs are handled.
> >
> >
> > There are still future improvements that could be made:
> >
> > pci-epf-test.c always allocates space for
> > 6 BARs, even when using 64-bit BARs (which
> > really only requires us to allocate 3 BARs).
> >
> > pcitest.sh will print "NOT OKAY" for BAR1,
> > BAR3, and BAR5 when using 64-bit BARs.
> > This could probably be improved to say
> > something like "N/A (64-bit BAR)".
> >
> > Niklas Cassel (12):
> > PCI: endpoint: BAR width should not depend on sizeof dma_addr_t
> > PCI: endpoint: Simplify epc->ops->set_bar()/pci_epc_set_bar()
> > PCI: endpoint: Setting BAR_5 to 64-bits wide is invalid
> > PCI: endpoint: Setting 64-bit/prefetch bit is invalid when IO is set
> > PCI: endpoint: Setting a BAR size > 4 GB is invalid if 64-bit flag is
> > not set
> > PCI: designware-ep: Make dw_pcie_ep_set_bar() handle 64-bit BARs
> > properly
> > PCI: cadence: Set PCI_BASE_ADDRESS_MEM_TYPE_64 if a 64-bit BAR was
> > set-up
> > PCI: endpoint: Handle 64-bit BARs properly
> > PCI: endpoint: Make epc->ops->clear_bar()/pci_epc_clear_bar() take
> > struct *epf_bar
> > PCI: endpoint: Make sure that BAR_5 does not have 64-bit flag set when
> > clearing
> > PCI: designware-ep: Make dw_pcie_ep_reset_bar() handle 64-bit BARs
> > properly
> > misc: pci_endpoint_test: Handle 64-bit BARs properly
> >
> > drivers/misc/pci_endpoint_test.c | 12 +++++----
> > drivers/pci/cadence/pcie-cadence-ep.c | 15 ++++++++---
> > drivers/pci/dwc/pcie-designware-ep.c | 36 +++++++++++++++++++++------
> > drivers/pci/endpoint/functions/pci-epf-test.c | 28 +++++++++++++--------
> > drivers/pci/endpoint/pci-epc-core.c | 32 +++++++++++++++---------
> > drivers/pci/endpoint/pci-epf-core.c | 4 +++
> > include/linux/pci-epc.h | 11 ++++----
> > include/linux/pci-epf.h | 2 ++
> > 8 files changed, 95 insertions(+), 45 deletions(-)
> >
>
> For the whole series:
>
> Tested-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>

Hello Gustavo,

Thanks a lot for testing!

Kind regards,
Niklas

\
 
 \ /
  Last update: 2018-04-02 21:48    [W:0.223 / U:4.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site