lkml.org 
[lkml]   [2018]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 09/11] x86/pti: enable global pages for shared areas
On Mon, Apr 2, 2018 at 10:27 AM, Dave Hansen
<dave.hansen@linux.intel.com> wrote:
>
> + /*
> + * The cpu_entry_area is shared between the user and kernel
> + * page tables. All of its ptes can safely be global.
> + */
> + if (boot_cpu_has(X86_FEATURE_PGE))
> + pte = pte_set_flags(pte, _PAGE_GLOBAL);

So this is where the quesion of "why is this conditional" is valid.

We could set _PAGE_GLOBAL unconditionally, not bothering with testing
X86_FEATURE_PGE.

Linus

\
 
 \ /
  Last update: 2018-04-02 19:56    [W:0.096 / U:5.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site