lkml.org 
[lkml]   [2018]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 01/11] x86/mm: factor out pageattr _PAGE_GLOBAL setting
On Mon, Apr 2, 2018 at 10:27 AM, Dave Hansen
<dave.hansen@linux.intel.com> wrote:
>
> Aside: _PAGE_GLOBAL is ignored when CR4.PGE=1, so why do we
> even go to the trouble of filtering it anywhere?

I'm assuming this is a typo, and you mean "when CR4.PGE=0".

The question you raise may be valid, but within the particular context
of *this* patch it is not.

In the context of this particular patch, the issue is that we use
_PAGE_GLOBAL as _PAGE_BIT_PROTNONE when the present bit isn't set.

Linus

\
 
 \ /
  Last update: 2018-04-02 19:52    [W:0.088 / U:4.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site