lkml.org 
[lkml]   [2018]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 答复: Re: [PATCH v2 ] scsi: Introduc e sdev_printk_ratelimited to throttlefrequent printk
On (04/02/18 13:14), wen.yang99@zte.com.cn wrote:
>
> > It's true that this print for the same device is useless. But it's
> > useful for different devices. Is it possible to limit the print only
> > for the same device?
>
> In our scene, it's  just for the same device (q->queuedata), Thanks.

Yes, what Jason meant was that rate limit struct is shared by different call
sites - including scsi_request_fn() from different devices.

If device1->scsi_request_fn()->sdev_printk_ratelimited() causes printk rate
limit, then messages from device2->scsi_request_fn()->sdev_printk_ratelimited()
may be lost entirely, unless you have enough of them.

-ss

\
 
 \ /
  Last update: 2018-04-02 07:30    [W:0.105 / U:4.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site