lkml.org 
[lkml]   [2018]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi
From
Date


On 3/27/2018 10:34 PM, Bjorn Andersson wrote:
> On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote:
>> + soc {
>> + pinctrl@1000000 {
>> + serial_0_pins: serial0_pinmux {
>
> Please, no underscores in the node name.

ok.

>
>> + mux {
>
> Fyi, you can put the pinctrl properties directly into the state node,
> omitting the "mux" level.
>

ok, will change.

>> + pins = "gpio16", "gpio17";
>> + function = "blsp_uart0";
>> + bias-disable;
>> + };
>> + };
>> +
>
> Apart from this the patch looks good.
Thanks.

Regards,
Sricharan

--
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

\
 
 \ /
  Last update: 2018-04-02 07:29    [W:0.085 / U:3.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site