Messages in this thread |  | | From | NeilBrown <> | Date | Wed, 18 Apr 2018 12:32:01 +1000 | Subject | Re: [PATCH 2/6] staging: lustre: remove libcfs/linux/libcfs.h |
| |
On Mon, Apr 16 2018, James Simmons wrote:
>> This include file is only included in one place, >> and only contains a list of other include directives. >> So just move all those to the place where this file >> is included, and discard the file. >> >> One include directive uses a local name ("linux-cpu.h"), so >> that needs to be given a proper path. >> >> Probably many of these should be remove from here, and moved to >> just the files that need them. > > Nak. Dumping all the extra headers from linux/libcfs.h to libcfs.h is > the wrong approach. The one header, libcfs.h, to be the only header > in all lustre files is the wrong approach. I have been looking to > unroll that mess. I have patch that I need to polish you that I can > submit.
I think we both have the same goal - maybe just different paths to get there. If you have something nearly ready to submit, I'm happy to wait for it, then proceed on top of it.
Thanks, NeilBrown [unhandled content-type:application/pgp-signature] |  |