lkml.org 
[lkml]   [2018]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] dcache: account external names as indirectly reclaimable memory
On Fri 13-04-18 22:35:19, Minchan Kim wrote:
> On Mon, Mar 05, 2018 at 01:37:43PM +0000, Roman Gushchin wrote:
[...]
> > @@ -1614,9 +1623,11 @@ struct dentry *__d_alloc(struct super_block *sb, const struct qstr *name)
> > name = &slash_name;
> > dname = dentry->d_iname;
> > } else if (name->len > DNAME_INLINE_LEN-1) {
> > - size_t size = offsetof(struct external_name, name[1]);
> > - struct external_name *p = kmalloc(size + name->len,
> > - GFP_KERNEL_ACCOUNT);
> > + struct external_name *p;
> > +
> > + reclaimable = offsetof(struct external_name, name[1]) +
> > + name->len;
> > + p = kmalloc(reclaimable, GFP_KERNEL_ACCOUNT);
>
> Can't we use kmem_cache_alloc with own cache created with SLAB_RECLAIM_ACCOUNT
> if they are reclaimable?

No, because names have different sizes and so we would basically have to
duplicate many caches.
--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2018-04-13 16:00    [W:0.135 / U:6.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site