[lkml]   [2018]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectRe: [PATCH v9 07/61] xarray: Add the xa_lock to the radix_tree_root
On Thu, Apr 12, 2018 at 02:59:32PM -0600, Ross Zwisler wrote:
> This is causing build breakage in the radix tree test suite in the
> current linux/master:
> ./linux/../../../../include/linux/idr.h: In function ‘idr_init_base’:
> ./linux/../../../../include/linux/radix-tree.h:129:2: warning:
> implicit declaration of function ‘spin_lock_init’; did you mean
> ‘spinlock_t’? [-Wimplicit-function-declaration]

Argh. That was added two patches later in
"xarray: Add definition of struct xarray":

diff --git a/tools/include/linux/spinlock.h b/tools/include/linux/spinlock.h
index b21b586b9854..4ec4d2cbe27a 100644
--- a/tools/include/linux/spinlock.h
+++ b/tools/include/linux/spinlock.h
@@ -6,8 +6,9 @@
#include <stdbool.h>

#define spinlock_t pthread_mutex_t
-#define DEFINE_SPINLOCK(x) pthread_mutex_t x = PTHREAD_MUTEX_INITIALIZER;
+#define spin_lock_init(x) pthread_mutex_init(x, NULL)

#define spin_lock_irqsave(x, f) (void)f, pthread_mutex_lock(x)
#define spin_unlock_irqrestore(x, f) (void)f, pthread_mutex_unlock(x)
I didn't pick up that it was needed this early on in the patch series.

 \ /
  Last update: 2018-04-12 23:11    [W:0.057 / U:1.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site